Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add checkmark icon to listboxes #694

Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat: add checkmark icon to listboxes #694

merged 6 commits into from
Jul 28, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Jul 18, 2023 •
edited
Loading

@luwes luwes self-assigned this Jul 18, 2023
@luwes luwes requested review from a team and heff as code owners July 18, 2023 19:39
@vercel
Copy link

vercel bot commented Jul 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 4:13pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 4:13pm

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #694 (83f8f9c) into main (a8cd4c0) will decrease coverage by 5.42%.
The diff coverage is 44.81%.

❗ Current head 83f8f9c differs from pull request most recent head d67eceb. Consider uploading reports for the commit d67eceb to get more accurate results

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   78.33%   72.91%   -5.42%     
==========================================
  Files          42       53      +11     
  Lines        8284     9836    +1552     
==========================================
+ Hits         6489     7172     +683     
- Misses       1795     2664     +869
Files Changed Coverage Δ
src/js/experimental/media-rendition-listbox.js 19.54% <10.71%> (ø)
src/js/experimental/media-playback-rate-listbox.js 23.80% <18.98%> (ø)
src/js/experimental/media-captions-listbox.js 30.52% <22.82%> (ø)
.../js/experimental/media-playback-rate-selectmenu.js 54.05% <42.85%> (ø)
src/js/media-captions-button.js 70.86% <54.83%> (ø)
src/js/experimental/media-chrome-selectmenu.js 23.76% <55.26%> (ø)
src/js/experimental/media-chrome-listbox.js 53.86% <61.26%> (ø)
src/js/experimental/media-captions-selectmenu.js 54.05% <66.66%> (ø)
src/js/experimental/media-rendition-selectmenu.js 54.05% <66.66%> (ø)
src/js/experimental/media-chrome-option.js 89.51% <86.36%> (ø)
... and 2 more

AdamJaggard
AdamJaggard approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@AdamJaggard AdamJaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, very useful for the new player theme

@luwes luwes force-pushed the checkmark branch 3 times, most recently from 9288704 to 2396a7d Compare July 28, 2023 15:34
@luwes luwes merged commit 110d28a into muxinc:main Jul 28, 2023
2 checks passed
@luwes luwes deleted the checkmark branch July 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamJaggard AdamJaggard AdamJaggard approved these changes

@heff heff Awaiting requested review from heff heff is a code owner

Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luwes @AdamJaggard